Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for Spring AMQP 2.4 #3584

Closed
garyrussell opened this issue Jun 23, 2021 · 4 comments
Closed

Add Support for Spring AMQP 2.4 #3584

garyrussell opened this issue Jun 23, 2021 · 4 comments
Assignees
@garyrussell
Labels
in: amqp type: refactoring
Milestone
5.5.2

Comments

@garyrussell
Copy link
Contributor

Make spring-integration-amqp compatible with both spring-amqp 2.3.x and 2.4.x.
@garyrussell garyrussell added this to the Backlog milestone Jun 23, 2021
@garyrussell garyrussell self-assigned this Jun 23, 2021
@garyrussell garyrussell modified the milestones: Backlog, 5.5.2 Jun 23, 2021
garyrussell added a commit to garyrussell/spring-integration that referenced this issue Jun 23, 2021
@garyrussell
spring-projectsGH-3584: Support spring-amqp 2.3.x and 2.4.x
6109d8e
artembilan added a commit to garyrussell/spring-integration that referenced this issue Jun 24, 2021
@artembilan
Merge branch 'main' into spring-projectsGH-3584
58f1b4d
artembilan pushed a commit that referenced this issue Jun 24, 2021
@garyrussell
GH-3584: Support spring-amqp 2.3.x and 2.4.x
76f77cc
@artembilan
Copy link
Member

Fixed via: 76f77cc

artembilan pushed a commit that referenced this issue Jul 26, 2021
@garyrussell @artembilan
GH-3584: Support spring-amqp 2.3.x and 2.4.x
2858954 
# Fix deprecation warning for Reactor's `limitRequest()`
@ae-govau
Copy link

Since updating to Spring Boot 2.5.3 (which bumps 5.5.1 to 5.5.2) one of our apps fails to start and report this error message:

Description:
An attempt was made to call a method that does not exist. The attempt was made from the following location:
     org.springframework.cloud.stream.binder.rabbit.RabbitMessageChannelBinder.createConsumerEndpoint(RabbitMessageChannelBinder.java:517)
The following method did not exist:
     'void org.springframework.integration.amqp.inbound.AmqpInboundChannelAdapter.<init>(org.springframework.amqp.rabbit.listener.AbstractMessageListenerContainer)'

I suspect that's related to this change?

I note the following related JARs in our app, each of which appear to be latest.

BOOT-INF/lib/spring-integration-amqp-5.5.2.jar - contains AmqpInboundChannelAdapter.class
BOOT-INF/lib/spring-cloud-stream-binder-rabbit-3.1.3.jar - contains RabbitMessageChannelBinder.class

I find the layout of the Spring projects quite complex so I'm not sure where best to report this issue, but figured I'd start here since I think this likely introduced the problem.

@artembilan
Copy link
Member

That’s correct : we did it here. We just missed the fact that Rabbit Binder is not going to release until September as a part of Spring Cloud release. See this issue for workaround for time being : #3601. Sorry for inconvenience

@ae-govau
Copy link

Thanks @artembilan 👍

artembilan added a commit to artembilan/spring-integration that referenced this issue Jul 30, 2021
@artembilan
spring-projectsGH-3601: Bring AMQP byte code compatibility back
b7ffa54 
Fixes spring-projects#3601

The issue spring-projects#3584
has introduced a regression when old constructor with an
`AbstractMessageListenerContainer` was removed in favor of just
`MessageListenerContainer`.
But with that change all the dependant projects must be recompiled,
which is not a case when Spring Cloud was not released against the
latest Spring Boot.

**Cherry-pick to `5.4.x`**
@artembilan artembilan mentioned this issue Jul 30, 2021
Merged
garyrussell pushed a commit that referenced this issue Jul 30, 2021
@artembilan @garyrussell
GH-3601: Bring AMQP byte code compatibility back
0a7ea59 
Fixes #3601

The issue #3584
has introduced a regression when old constructor with an
`AbstractMessageListenerContainer` was removed in favor of just
`MessageListenerContainer`.
But with that change all the dependant projects must be recompiled,
which is not a case when Spring Cloud was not released against the
latest Spring Boot.

**Cherry-pick to `5.4.x`**
garyrussell pushed a commit that referenced this issue Jul 30, 2021
@artembilan @garyrussell
GH-3601: Bring AMQP byte code compatibility back
d7a7bbb 
Fixes #3601

The issue #3584
has introduced a regression when old constructor with an
`AbstractMessageListenerContainer` was removed in favor of just
`MessageListenerContainer`.
But with that change all the dependant projects must be recompiled,
which is not a case when Spring Cloud was not released against the
latest Spring Boot.

**Cherry-pick to `5.4.x`**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garyrussell garyrussell

Labels
in: amqp type: refactoring
Projects
None yet
Milestone
5.5.2
Development

No branches or pull requests
3 participants
@garyrussell @artembilan @ae-govau