Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More refactoring to use a LogAccessor from the IntegrationObjectSupport #3424

Closed
artembilan opened this issue Nov 6, 2020 · 5 comments · Fixed by #3588
Closed

More refactoring to use a LogAccessor from the IntegrationObjectSupport #3424

artembilan opened this issue Nov 6, 2020 · 5 comments · Fixed by #3588
Labels
ideal-for-user-contribution An issue that would ideal for a user to get started with contributing. in: core type: enhancement
Milestone

Comments

@artembilan
Copy link
Member

For example an AbstractPollingEndpoint and its code like this:

if (logger.isDebugEnabled()) {
	logger.debug("Poll interrupted - during stop()? : " + e.getMessage());
}
@artembilan artembilan added this to the 6.0.x milestone Nov 6, 2020
@artembilan artembilan modified the milestones: 6.0.x, 5.5.0-RC1 Mar 23, 2021
@artembilan artembilan assigned artembilan and unassigned artembilan Mar 23, 2021
@artembilan artembilan added the ideal-for-user-contribution An issue that would ideal for a user to get started with contributing. label Mar 23, 2021
@artembilan artembilan modified the milestones: 5.5.0-RC1, Backlog Mar 23, 2021
@trgpa
Copy link
Contributor

trgpa commented Jul 12, 2021

Am I correct to assume that we need to remove the LogAccessor.is***Enabled()s and replace them with LogAccessor.***(Supplier<? extends CharSequence> messageSupplier)? For example in OperationInvokingMessageHandler.java:

if (logger.isWarnEnabled()) {
	logger.warn("This component doesn't expect a reply. " +
			"The MBean operation '" + operation + "' result '" + result +
			"' for '" + objectName + "' is ignored.");
}

to

logger.warn(() -> "This component doesn't expect a reply. " +
		"The MBean operation '" + operation + "' result '" + result +
		"' for '" + objectName + "' is ignored.");

@artembilan
Copy link
Member Author

That’s correct, @trungPa .
Looking forward for your contribution !
Thank you!

@trgpa
Copy link
Contributor

trgpa commented Jul 12, 2021

@artembilan can you assign this issue and #3549 to me?

@artembilan
Copy link
Member Author

Unfortunately that’s not how GitHub works: we can assign only someone who is a part of the team or belongs to specially created group with an appropriate permission. Since in the end with the final merged contribution it doesn’t matter we don’t use that special group and say something in the issue comment that you claim it should be enough for external contributors to determine that this one is in progress . On the other hand I can assign it to myself to avoid any possible confusions while you are working on it.
does it make sense ?

@trgpa
Copy link
Contributor

trgpa commented Jul 12, 2021

@artembilan it sounds good.
So I'm leaving a comment here to say that I've been working on this issue.

trgpa added a commit to trgpa/spring-integration that referenced this issue Jul 13, 2021
@artembilan artembilan modified the milestones: Backlog, 5.5.2 Jul 13, 2021
artembilan pushed a commit that referenced this issue Jul 19, 2021
Fixes #3424

* Use `LogMessage.format()` for lazily formatting

* Fix some logging statements in `JdbcChannelMessageStore`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ideal-for-user-contribution An issue that would ideal for a user to get started with contributing. in: core type: enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants