Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use JOOQ functionality to determine dialect #36991

Closed
wants to merge 1 commit into from

Conversation

ramilS
Copy link

@ramilS ramilS commented Aug 15, 2023

No description provided.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Aug 15, 2023
@ramilS ramilS force-pushed the feature/removeNullCheck branch from e836374 to 05bde90 Compare August 15, 2023 17:14
@ramilS ramilS changed the title Remove unnecessary nullcheck Use JOOQ functionality to determine dialect Aug 15, 2023
@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 16, 2023
@snicoll snicoll added this to the 3.2.0-M2 milestone Aug 16, 2023
@snicoll snicoll self-assigned this Aug 16, 2023
snicoll pushed a commit that referenced this pull request Aug 16, 2023
@snicoll snicoll closed this in 5762e41 Aug 16, 2023
@snicoll
Copy link
Member

snicoll commented Aug 16, 2023

Thanks for making your first contribution to Spring Boot @ramilS. I've polished things a bit further as JOOQ allows to pass a null connection.

@ramilS ramilS deleted the feature/removeNullCheck branch August 16, 2023 19:07
Copy link

@Laxonj Laxonj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants