Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MongoPagingItemReader never reset page number #1086

Closed
spring-projects-issues opened this issue Jul 15, 2016 · 1 comment
Closed

MongoPagingItemReader never reset page number #1086

spring-projects-issues opened this issue Jul 15, 2016 · 1 comment
Labels
for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line in: infrastructure related-to: item-readers-writers type: bug
Milestone
5.2.1

Comments

@spring-projects-issues
Copy link
Collaborator

Oleksandr Loushkin opened BATCH-2517 and commented

MongoItemReader should override doClose() method with reset page number.
Otherwise page will never be returned to 0.

As we can see AbstractPaginatedDataItemReader increases page by page ++

For example RepositoryItemReader has method.

I can create pull request with quick fix.

Affects: 3.0.7
@spring-projects-issues spring-projects-issues added type: bug status: waiting-for-triage Issues that we did not analyse yet labels Dec 16, 2019
@adsanche
Copy link

Hi, looks like the doClose() method still unimplemented on MongoItemReader, is it still considered a bug to be fixed?

@hpoettker hpoettker mentioned this issue Dec 6, 2024
Closed
@fmbenhassine fmbenhassine added in: infrastructure and removed status: waiting-for-triage Issues that we did not analyse yet labels Dec 17, 2024
@fmbenhassine fmbenhassine added this to the 5.2.1 milestone Dec 17, 2024
@fmbenhassine fmbenhassine changed the title MongoItemReader never reset page number. [BATCH-2517] MongoPagingItemReader never reset page number Dec 17, 2024
fmbenhassine pushed a commit that referenced this issue Dec 17, 2024
@hpoettker @fmbenhassine
Add state reset on close of AbstractPaginatedDataItemReader
e044030 
Resolves #1086
@fmbenhassine fmbenhassine added the for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line label Dec 17, 2024
@fmbenhassine fmbenhassine mentioned this issue Dec 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
for: backport-to-5.1.x Issues that will be back-ported to the 5.1.x line in: infrastructure related-to: item-readers-writers type: bug
Projects
None yet
Milestone
5.2.1
Development

Successfully merging a pull request may close this issue.

Add state reset on close of MongoPagingItemReader hpoettker/spring-batch
3 participants
@fmbenhassine @adsanche @spring-projects-issues