Improved DefaultSpanNamer #2234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as a default toString.
paulbakker
force-pushed
the
improved-default-span-namer
branch
from
4d52540 to
cfc183a
Compare
marcingrzejszczak
added a commit
that referenced
this pull request
Dec 16, 2022
this has caused issues in async spans and runnables where the toString didn't come from Object but was a default from classes such as e.g. FutureTask related issue #2234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved
DefaultSpanNamer. It now more efficiently checks if the delegate has a default toString.Previously it would actually call the toString and compare the value of the String. This is expensive as it creates more garbage.