Batch application does not shutdown #2217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a batch application ends, the application does not shut down.
It is due to the thread created by ZipkinAutoConfiguration (non deamon thread) is supposed to be terminated at:
But it is not executed because still exists a non daeman thread. (The thread create by the zipkinExecutor itself)
At the PR you can see that the executor is shutdown when the task is completed. I think it is the best option because it is not used anymore.
Also the shutdown is executed by the executor thread itself, in order to not block the main thread which is executing the startup of the application.
I have attached a simple batch application which does nothing a part from starting and stopping to check the issue.
spring-batch.zip