This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Fix docker-lab/helios#462 (Authentication against private registry.hub.docker.com repositories) #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 53.06% (diff: 41.17%)@@ master #473 diff @@
==========================================
Files 80 84 +4
Lines 2973 4067 +1094
Methods 0 0
Messages 0 0
Branches 417 618 +201
==========================================
+ Hits 1529 2158 +629
- Misses 1308 1726 +418
- Partials 136 183 +47
|
|
@elifarley sorry for the delayed review, but can you provide some more context on what |
|
Sorry, I should have typed something else: Fixed now. |
elifarley
changed the title
|
👍 |
|
@elifarley thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is