Add flag to skip inserting notes into the database #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecamacho
commented
Apr 29, 2021
| @@ -0,0 +1,56 @@ | |||
| // Copyright (c) 2020 Spotify AB. | |||
There was a problem hiding this comment.
I created a new Shared module between the client and the backend to held the models used by both. At the moment, it only contains this one. But I plan to refactor in the future to move more things here and avoid code duplication.
polac24
approved these changes
Apr 29, 2021
Sources/XCMetricsClient/Mobius/Domain/MetricsUploaderLoopTypes.swift
Outdated
Show resolved
Hide resolved
| /// Don't process the Notes found in the log | ||
| /// In some cases, we can have thousands of these that can make database grow exponentially | ||
| /// while providing little value | ||
| public let skipNotes: Bool? |
….swift Co-authored-by: Bartosz Polaczyk <polac24@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, a log can contain thousands of Notes. For instance, if it has a lot of modules and is running SwiftLint as a PostBuild Phase's script. Inserting this data to the Database, can make it grow exponentially.
This PR adds an option:
--skipNotes falsethat can be passed to theXCMetricscommand so all those notes won't be inserted.