Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warning with Redis 4.8.0 #701

Merged

Conversation

martingregoire
Copy link
Contributor

@martingregoire martingregoire commented Jan 13, 2023

Fixes the following deprecation warning when using Redis 4.8.0:

Redis#sadd will always return an Integer in Redis 5.0.0.
Use Redis#sadd? instead.

As the return value of redis.sadd is not used, we can simply replace the .sadd call with .sadd?.

see

Fixes the following deprecation warning when using Redis 4.8.0:

```
Redis#sadd will always return an Integer in Redis 5.0.0.
Use Redis#sadd? instead.
```

As the return value of `redis.sadd` is not used, we can simply replace
the `.sadd` call with `.sadd?`.

see https://github.com/redis/redis-rb/blob/4.x/CHANGELOG.md#480
see splitrb#700
Copy link
Member

@andrehjr andrehjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants