Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolvedExpectedArtifacts not populated when using orca's SQL pipelineRef feature #6993

Closed
dethi opened this issue Nov 18, 2024 · 4 comments
Closed

Comments

@dethi
Copy link

dethi commented Nov 18, 2024

Issue Summary:

orca's SQL pipelineRef feature doesn't populate the resolvedExpectedArtifacts field, causing error when using #triggerResolvedArtifact(String name).

Cloud Provider(s):

  • GCP
  • Kubernetes

Environment:

  • Spinnaker 1.35.4
  • Using pipeline trigger to propagate between clusters. Pipeline A deploy the Cluster A. Pipeline B has a trigger set to match successful run of pipeline B. Pipeline B match the docker artifacts of Pipeline A to decide which version to deploy.

Feature Area:

  • Pipeline trigger

Steps to Reproduce:

  • Spinnaker 1.35.4, with Orca config: executionRepository.sql.enabled=true and executionRepository.sql.pipelineRef.enabled=true
  • Create two pipeline, pipelineA and pipelineB
  • PipelineB has an automated trigger on pipelineA successful execution, with an artifact constraints
  • PipelineB has an Evaluate Variables stage that use #triggerResolvedArtifact(String name) to use the expected artifact.
  • Trigger pipelineA and see pipelineB triggering successfully but the resolvedExpectedArtifacts field is empty causing the Evaluate Variables stage to fail

Additional Details:

"expressionEvaluationSummary": {
                    "trigger['expectedArtifacts'][0]['boundArtifact']['version']": [
                        {
                            "description": "Failed to evaluate [COMMITID] EL1012E: Cannot index into a null value",
                            "exceptionType": "org.springframework.expression.spel.SpelEvaluationException",
                            "level": "ERROR",
                            "timestamp": 1731919796541
                        }
                    ]
                },
  • Trigger setup:
Screenshot 2024-11-18 at 09 42 56
@edgarulg
Copy link

edgarulg commented Dec 7, 2024

thanks for submitting the bug @dethi. I was able to reproduce the issue and I will be working on a fix for this.

@edgarulg
Copy link

I raised a PR with the fix for this issue: spinnaker/orca#4816

@edgarulg
Copy link

@dethi the fix for this issue was merged and backported. We still need to create a new patch release to deliver it. I will close this issue if you agree and you can re-open it if you still see issues.

@dethi
Copy link
Author

dethi commented Dec 14, 2024

Thanks! I will test again when released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants