fix(pipelineRef): add resolvedExpectedArtifacts from pipelineTrigger to PipelineRefTrigger #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to PipelineRefTrigger
edgarulg
requested review from
xibz,
jasonmcintosh,
link108,
christosarvanitis and
dbyron-sf
|
this fix needs to be backported to 1.36.x and 1.35.x |
|
Tests please. |
|
sure, let me add test around it |
xibz
reviewed
Dec 11, 2024
...sql/src/main/kotlin/com/netflix/spinnaker/orca/sql/PipelineRefTriggerDeserializerSupplier.kt
Show resolved
Hide resolved
|
@jasonmcintosh I added tests and PR is ready for review |
jasonmcintosh
approved these changes
Dec 12, 2024
|
NOT sure we won't hit more cases but... kinda hoping we can keep this as small as possible... |
|
@Mergifyio backport release-1.36.x release-1.35.x |
✅ Backports have been created
|
mergify bot
added a commit
that referenced
this pull request
Dec 13, 2024
…to PipelineRefTrigger (#4816) (#4817) * fix(pipelineRef): add resolvedExpectedArtifacts from pipelineTrigger to PipelineRefTrigger * fix(pipelineRef): add tests around PipelineRefTrigger --------- Co-authored-by: Jason <jason.mcintosh@harness.io> (cherry picked from commit 3c65fe0) Co-authored-by: Edgar Garcia <63310723+edgarulg@users.noreply.github.com>
mergify bot
added a commit
that referenced
this pull request
Dec 13, 2024
…to PipelineRefTrigger (#4816) (#4818) * fix(pipelineRef): add resolvedExpectedArtifacts from pipelineTrigger to PipelineRefTrigger * fix(pipelineRef): add tests around PipelineRefTrigger --------- Co-authored-by: Jason <jason.mcintosh@harness.io> (cherry picked from commit 3c65fe0) Co-authored-by: Edgar Garcia <63310723+edgarulg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spel expressions with the function
#triggerResolvedArtifactare throwing an evaluation error when pipelineRef feature is enabled in Orca. See: spinnaker/spinnaker#6993The error happens because when we transform a PipelineTrigger into a PipelineRefTrigger we are not populating the
resolvedExpectedArtifacts. As theresolvedExpectedArtifactsis empty the Spel function#triggerResolvedArtifactis not able to collect the artifact we want.This small code change fix the issue.