fix(caching): K8s cache affected when not enough permissions in service account #5742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… not neough permissions in the service account exist but because we are throwing an error even partial entries are not being cached
mattgogerly
reviewed
Jun 22, 2022
| @@ -453,8 +453,14 @@ public ImmutableList<KubernetesManifest> list( | |||
| parseManifestList()); | |||
|
|
|||
| if (status.getResult() != JobResult.Result.SUCCESS) { | |||
| throw new KubectlException( | |||
| "Failed to read " + kinds + " from " + namespace + ": " + status.getError()); | |||
| boolean permissionError = | |||
There was a problem hiding this comment.
Is using Apache Commons necessary? The next if block below just does a simple contains
There was a problem hiding this comment.
not really I just wanted to minimize the risk in case the k8s message could change in a future version. aka from "forbidden" -> Forbidden/FORBIDDEN
link108
approved these changes
Jun 24, 2022
|
@Mergifyio backport release-1.28.x release-1.27.x release-1.26.x |
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k8s-kind listing is able to return partial results when not enough permissions in the service account exist but because we are throwing an error even partial entries are not being cached.
This fix will not throw an error when it is permission related only for k8s caching.