Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gitrepo): Support to authenticate with user and token #5733

Merged
merged 1 commit into from
Jun 14, 2022

Conversation

nemesisOsorio
Copy link
Member

Cloning Bitbucket is failing for git repo artifact using username and token
image

After this change we tested different scenarios including Github
image

@ovidiupopa07
Copy link
Contributor

LGTM

@link108 link108 added the ready to merge Approved and ready for a merge label Jun 14, 2022
@mergify mergify bot added the auto merged Merged automatically by a bot label Jun 14, 2022
Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com>
@nemesisOsorio nemesisOsorio force-pushed the fix/gitrepo_auth_token branch from 0794379 to cf1c6f6 Compare June 14, 2022 17:52
@mergify mergify bot merged commit 8d8686b into spinnaker:master Jun 14, 2022
@link108
Copy link
Member

link108 commented Jun 14, 2022

@Mergifyio backport release-1.28.x

mergify bot pushed a commit that referenced this pull request Jun 14, 2022
Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com>

Co-authored-by: Ovidiu Popa <ovidiu.popa@armory.io>
(cherry picked from commit 8d8686b)
@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2022

backport release-1.28.x

✅ Backports have been created

mergify bot added a commit that referenced this pull request Jun 14, 2022
)

Co-authored-by: Nemesis Osorio <nemesis211_6@hotmail.com>

Co-authored-by: Ovidiu Popa <ovidiu.popa@armory.io>
(cherry picked from commit 8d8686b)

Co-authored-by: nemesisOsorio <nemesis211_6@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto merged Merged automatically by a bot ready to merge Approved and ready for a merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants