feat(test): Add ECS CreateServerGroupTests for task definition input #4957
Conversation
|
The following commits need their title changed:
Please format your commit title into the form:
This allows us to easily generate changelogs & determine semantic version numbers when cutting releases. You can read more about commit conventions here. |
| @Test | ||
| public void createSGOWithInputsFargateLegacyTargetGroupTest() throws IOException { | ||
| /** | ||
| * TODO (pbhingre): Ideally this test would go further and actually assert that the resulting |
There was a problem hiding this comment.
instead of copying this comment from the first test everywhere how about we just move the original comment to the top of this class, since it applies to all of these test cases at the moment?
| */ | ||
|
|
||
| // given | ||
| String url = getTestUrl("/ecs/ops/createServerGroup"); |
There was a problem hiding this comment.
since we're using this same path in every createServerGroup test, let's extract it as a class-level var and use that instead
| String url = getTestUrl("/ecs/ops/createServerGroup"); | ||
| String requestBody = | ||
| generateStringFromTestFile( | ||
| "/createServerGroupOperation-inputs-fargate-NewTargetGroup.json"); |
There was a problem hiding this comment.
nit: let's name this file after the new field (and lower case the word to keep consistent):
"createServerGroupOperation-inputs-fargate-targetGroupMappings.json"
There was a problem hiding this comment.
Changed the file name to "createServerGroupOperation-inputs-fargate-targetGroupMappings.json"
| "targetGroup" : "spin-fargate-instanceTG" | ||
| } | ||
| ], | ||
| "source" : { |
There was a problem hiding this comment.
what happens if we don't include this source arg, does it fail?
There was a problem hiding this comment.
Source is not required. It was added as a next part of the testing but not really required for this test.
|
@paragbhingre since this has a |
paragbhingre
changed the title
paragbhingre
force-pushed
the
ecs-integ-final
branch
from
673cd5c to
02bd808
Compare
...s/src/integration/java/com/netflix/spinnaker/clouddriver/ecs/test/CreateServerGroupSpec.java
Outdated
Show resolved
Hide resolved
paragbhingre
force-pushed
the
ecs-integ-final
branch
from
a6cddab to
abca3d1
Compare
This PR contains integration tests for Create Server Group Operation for the task definition type as input.
There are total 2 tests:
Related to : Clouddriver integration test