Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(google): return null guards to GoogleApplicationProvider #3921

Merged
merged 2 commits into from
Aug 6, 2019
Merged

fix(google): return null guards to GoogleApplicationProvider #3921

merged 2 commits into from
Aug 6, 2019

Conversation

maggieneterval
Copy link
Contributor

My bad! 🙈 😭
GoogleApplicationProvider.getApplication can be called with non-GCE application names, so we cannot assume 1) That we can build an instance of ApplicationCacheData (should default to null) or 2) That we will have a non-null instance of ApplicationCacheData downstream.

@maggieneterval maggieneterval requested a review from plumpy August 6, 2019 18:53
plumpy
plumpy approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@plumpy plumpy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add @Nullable to GoogleApplicationProvider#getApplicationCacheData(String) (on line 78... apparently I can't add a review comment to an unchanged line)

but yeah, rad!

@maggieneterval
Copy link
Contributor Author

Thank you, it has been nullabled!

@maggieneterval maggieneterval merged commit f64685f into spinnaker:master Aug 6, 2019
@maggieneterval maggieneterval deleted the fix-app-null branch August 6, 2019 20:46
maggieneterval added a commit to maggieneterval/clouddriver that referenced this pull request Aug 8, 2019
@maggieneterval
fix(google): return null guards to GoogleApplicationProvider (spinnak…
10a3a7a 
…er#3921)

* fix(google): return null guards to GoogleApplicationProvider

* fix(google): add @nullable annotation to GoogleApplicationProvider
@maggieneterval maggieneterval mentioned this pull request Aug 8, 2019
Merged
maggieneterval added a commit that referenced this pull request Aug 8, 2019
@maggieneterval
fix(google): return null guards to GoogleApplicationProvider (#3921)
0069e93 
* fix(google): return null guards to GoogleApplicationProvider

* fix(google): add @nullable annotation to GoogleApplicationProvider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plumpy plumpy plumpy approved these changes

Assignees
No one assigned
Labels
target-release/1.16
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maggieneterval @plumpy @spinnakerbot