Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openstack): Fix openstack unit tests #3402

Merged
merged 1 commit into from
Feb 21, 2019
Merged

fix(openstack): Fix openstack unit tests #3402

merged 1 commit into from
Feb 21, 2019

Conversation

ezimanyi
Copy link
Contributor

The openstack unit tests fail when run locally using gradle; the root cause is that the tests are not independent, as there is a test that does metaprogramming to change the behavior of a class.

@ezimanyi ezimanyi requested a review from dibyom February 21, 2019 01:11
The openstack unit tests fail when run locally using gradle;
the root cause is that the tests are not independent, as there
is a test that does metaprogramming to change the behavior of
a class.
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ezimanyi ezimanyi merged commit 8924760 into spinnaker:master Feb 21, 2019
@ezimanyi ezimanyi deleted the fix-openstack-tests branch February 21, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants