Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(provider/ecs): Handle different CPU/mem limit settings in server group details view #3203

Merged
merged 2 commits into from
Dec 6, 2018
Merged

fix(provider/ecs): Handle different CPU/mem limit settings in server group details view #3203

merged 2 commits into from
Dec 6, 2018

Conversation

clareliguori
Copy link
Member

Handle hard memory container limits, task level CPU/mem limits, and no port mappings in ECS task definition

Fixes spinnaker/spinnaker#3481

@clareliguori
fix(provider/ecs): Handle different CPU/mem limit settings in server …
f3ff5a9 
…group details view

Handle hard memory container limits, task level CPU/mem limits, and no port mappings in ECS task definition.  Cache task definition-level CPU/memory
@clareliguori
Copy link
Member Author

Example output:

  "taskDefinition": {
    "containerImage": "clareliguori/private-images:spinnaker-demo-latest",
    "containerPort": 80,
    "cpuUnits": 256,
    "environmentVariables": [
      {
        "name": "CLOUD_DETAIL",
        "value": "spinnakersummit"
      },
      {
        "name": "SERVER_GROUP",
        "value": "v0008"
      },
      {
        "name": "CLOUD_STACK",
        "value": "ecsdemo"
      }
    ],
    "iamRole": "None",
    "memoryLimit": 512,
    "memoryReservation": 0,
    "taskName": "aws-ecsdemo-spinnakersummit:13"
  },

@clareliguori clareliguori mentioned this pull request Dec 4, 2018
Merged
@tomaslin
Copy link
Contributor

tomaslin commented Dec 6, 2018

LGTM

@tomaslin tomaslin merged commit 4fb24d2 into spinnaker:master Dec 6, 2018
@clareliguori clareliguori deleted the view-cpu-mem-limits branch December 6, 2018 18:02
clanesf pushed a commit to clanesf/clouddriver that referenced this pull request Dec 8, 2018
@clareliguori @clanesf
fix(provider/ecs): Handle different CPU/mem limit settings in server …
dd38544 
…group details view (spinnaker#3203)

Handle hard memory container limits, task level CPU/mem limits, and no port mappings in ECS task definition.  Cache task definition-level CPU/memory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
target-release/1.12
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clareliguori @tomaslin @spinnakerbot