feat(provider/gce): Limit GCE batch sizes. #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwander
approved these changes
Nov 6, 2018
...ine/src/main/groovy/com/netflix/spinnaker/clouddriver/appengine/deploy/AppengineUtils.groovy
Show resolved
Hide resolved
...src/main/groovy/com/netflix/spinnaker/clouddriver/googlecommon/batch/GoogleBatchRequest.java
Outdated
Show resolved
Hide resolved
...src/main/groovy/com/netflix/spinnaker/clouddriver/googlecommon/batch/GoogleBatchRequest.java
Outdated
Show resolved
Hide resolved
...src/main/groovy/com/netflix/spinnaker/clouddriver/googlecommon/batch/GoogleBatchRequest.java
Outdated
Show resolved
Hide resolved
...src/main/groovy/com/netflix/spinnaker/clouddriver/googlecommon/batch/GoogleBatchRequest.java
Outdated
Show resolved
Hide resolved
...src/main/groovy/com/netflix/spinnaker/clouddriver/googlecommon/batch/GoogleBatchRequest.java
Outdated
Show resolved
Hide resolved
...src/main/groovy/com/netflix/spinnaker/clouddriver/googlecommon/batch/GoogleBatchRequest.java
Outdated
Show resolved
Hide resolved
...src/main/groovy/com/netflix/spinnaker/clouddriver/googlecommon/batch/GoogleBatchRequest.java
Outdated
Show resolved
Hide resolved
...src/main/groovy/com/netflix/spinnaker/clouddriver/googlecommon/batch/GoogleBatchRequest.java
Outdated
Show resolved
Hide resolved
ttomsu
reviewed
Nov 6, 2018
...src/main/groovy/com/netflix/spinnaker/clouddriver/googlecommon/batch/GoogleBatchRequest.java
Outdated
Show resolved
Hide resolved
Adds a new class to limit GCE batch sizes, adds a hook to PaginatedRequest using the new batch class, and exercises both using the regional server group caching agent as the guinea pig.
ttomsu
pushed a commit
to ttomsu/clouddriver
that referenced
this pull request
Nov 12, 2018
This reverts commit 9ce9a66.
ttomsu
pushed a commit
to ttomsu/clouddriver
that referenced
this pull request
Nov 12, 2018
This reverts commit 9ce9a66.
ezimanyi
pushed a commit
that referenced
this pull request
Nov 12, 2018
jtk54
added a commit
to jtk54/clouddriver
that referenced
this pull request
Nov 13, 2018
* feat(provider/gce): Limits GCE batch sizes. Adds a new class to limit GCE batch sizes, adds a hook to PaginatedRequest using the new batch class, and exercises both using the regional server group caching agent as the guinea pig. * feat(provider/gce): Adds new GoogleBatchRequest to all callsites. * chore(provider/gce): Adds instrumentation to new batches. * chore(provider/gce): Update specs for new batching mechanism. * refactor(provider/gce): Switch to local threadpool for new batches.
jtk54
added a commit
that referenced
this pull request
Nov 14, 2018
…3156) * feat(provider/gce): Limit GCE batch sizes. (#3125) * feat(provider/gce): Limits GCE batch sizes. Adds a new class to limit GCE batch sizes, adds a hook to PaginatedRequest using the new batch class, and exercises both using the regional server group caching agent as the guinea pig. * feat(provider/gce): Adds new GoogleBatchRequest to all callsites. * chore(provider/gce): Adds instrumentation to new batches. * chore(provider/gce): Update specs for new batching mechanism. * refactor(provider/gce): Switch to local threadpool for new batches. * fix(provider/gce): Avoid blackholing Exceptions from CachingAgents.
clanesf
pushed a commit
to clanesf/clouddriver
that referenced
this pull request
Dec 8, 2018
* feat(provider/gce): Limits GCE batch sizes. Adds a new class to limit GCE batch sizes, adds a hook to PaginatedRequest using the new batch class, and exercises both using the regional server group caching agent as the guinea pig. * feat(provider/gce): Adds new GoogleBatchRequest to all callsites. * chore(provider/gce): Adds instrumentation to new batches. * chore(provider/gce): Update specs for new batching mechanism. * refactor(provider/gce): Switch to local threadpool for new batches.
clanesf
pushed a commit
to clanesf/clouddriver
that referenced
this pull request
Dec 8, 2018
* Revert "fix(provider/gce): Wait for batch requests to finish before returning (spinnaker#3149)" This reverts commit f3c0ab7. * Revert "feat(provider/gce): Limit GCE batch sizes. (spinnaker#3125)" This reverts commit 9ce9a66.
clanesf
pushed a commit
to clanesf/clouddriver
that referenced
this pull request
Dec 8, 2018
…pinnaker#3156) * feat(provider/gce): Limit GCE batch sizes. (spinnaker#3125) * feat(provider/gce): Limits GCE batch sizes. Adds a new class to limit GCE batch sizes, adds a hook to PaginatedRequest using the new batch class, and exercises both using the regional server group caching agent as the guinea pig. * feat(provider/gce): Adds new GoogleBatchRequest to all callsites. * chore(provider/gce): Adds instrumentation to new batches. * chore(provider/gce): Update specs for new batching mechanism. * refactor(provider/gce): Switch to local threadpool for new batches. * fix(provider/gce): Avoid blackholing Exceptions from CachingAgents.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.