Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws/subnet): Add accountId to subnet endpoints #3101

Merged
merged 3 commits into from
Oct 30, 2018
Merged

feat(aws/subnet): Add accountId to subnet endpoints #3101

merged 3 commits into from
Oct 30, 2018

Conversation

gardleopard
Copy link
Contributor

@gardleopard gardleopard commented Oct 29, 2018 •
edited
Loading

This adds accountId to the subnet endpoints for aws.

[{
  "account" : "default",
  "accountId" : "3467647654778",
  "availabilityZone" : "eu-central-1c",
  "availableIpAddressCount" : 4091,
  "cidrBlock" : "172.31.16.0/20",
  "deprecated" : false,
  "id" : "subnet-0832b072",
  "purpose" : null,
  "region" : "eu-central-1",
  "state" : "available",
  "target" : null,
  "type" : "aws",
  "vpcId" : "vpc-d023e5b4"
}]

@gardleopard
feat(aws/subnet): Add accountId to subnet endpoints
bb02d31 
This adds accountId to the subnet endpoints for aws.
@gardleopard gardleopard mentioned this pull request Oct 29, 2018
Closed
@gardleopard gardleopard requested a review from cfieber October 29, 2018 20:08
octopatch
octopatch approved these changes Oct 30, 2018
View reviewed changes
Copy link

@octopatch octopatch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomaslin tomaslin merged commit 4da8e90 into spinnaker:master Oct 30, 2018
clanesf pushed a commit to clanesf/clouddriver that referenced this pull request Dec 8, 2018
@gardleopard @clanesf
feat(aws/subnet): Add accountId to subnet endpoints (spinnaker#3101)
714794e 
This adds accountId to the subnet endpoints for aws.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@octopatch octopatch octopatch approved these changes

@cfieber cfieber Awaiting requested review from cfieber

Assignees
No one assigned
Labels
target-release/1.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gardleopard @octopatch @tomaslin @spinnakerbot