Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(artifact/oracle): Added oracle artifact. #2990

Merged
merged 3 commits into from
Sep 26, 2018
Merged

feat(artifact/oracle): Added oracle artifact. #2990

merged 3 commits into from
Sep 26, 2018

Conversation

guoyongzhang
Copy link
Contributor

@guoyongzhang guoyongzhang commented Sep 26, 2018 •
edited
Loading

Added oracle type artifact. The related haylard PR is spinnaker/halyard#1041.

@guoyongzhang guoyongzhang mentioned this pull request Sep 26, 2018
Merged
lwander
lwander approved these changes Sep 26, 2018
View reviewed changes
Copy link
Member

@lwander lwander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@guoyongzhang
Copy link
Contributor Author

Thank you for the approval. Could you merge it after it passes the checks?

@tomaslin tomaslin merged commit 8f106c7 into spinnaker:master Sep 26, 2018
@guoyongzhang guoyongzhang deleted the oracle_artifact branch September 27, 2018 13:21
clanesf pushed a commit to clanesf/clouddriver that referenced this pull request Dec 8, 2018
@guoyongzhang @clanesf
feat(artifact/oracle): Added oracle artifact. (spinnaker#2990)
5278168
@danielpeach danielpeach mentioned this pull request Sep 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwander lwander lwander approved these changes

Assignees
No one assigned
Labels
target-release/1.10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guoyongzhang @lwander @tomaslin @spinnakerbot