cleanup(aws): Avoid scheduling ReconcileClassicLinkSecurityGroupsAgent
#2466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asher
reviewed
Mar 29, 2018
| @@ -84,7 +88,7 @@ default Moniker convertOnDemandDetails(Map<String, String> details) { | |||
| .sequence(Integer.valueOf(details.get("sequence"))) | |||
There was a problem hiding this comment.
While in here, also change Integer.valueOf to something null safe.
|
Oh ya, of course @asher! Thanks.
…On Wed, Mar 28, 2018 at 10:59 PM Asher Feldman ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In
clouddriver-core/src/main/groovy/com/netflix/spinnaker/clouddriver/cache/OnDemandAgent.java
<#2466 (comment)>
:
> @@ -84,7 +88,7 @@ default Moniker convertOnDemandDetails(Map<String, String> details) {
.sequence(Integer.valueOf(details.get("sequence")))
While in here, also change Integer.valueOf to something null safe.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2466 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAXuLFhZgj7UXITRVvUHAq4NB_nhqGuKks5tjHhLgaJpZM4S_twz>
.
|
cfieber
approved these changes
Mar 29, 2018
ajordens
force-pushed
the
avoid-registering-reconcileclassiclinksecuritygroupsagent
branch
from
e4677b0 to
7c8d4d7
Compare
Only schedule this agent for accounts where it is explicitly enabled. This PR also cleans up some unnecessary usage of `e.printStackTrace()`.
ajordens
force-pushed
the
avoid-registering-reconcileclassiclinksecuritygroupsagent
branch
from
7c8d4d7 to
30c5ac7
Compare
ajordens
deleted the
avoid-registering-reconcileclassiclinksecuritygroupsagent
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only schedule this agent for accounts where it is explicitly enabled.
This PR also cleans up some unnecessary usage of
e.printStackTrace().