Skip to content

Commit

Permalink
chore(titus): limit protobuf to 3.17.3 (#5706) (#5714)
Browse files Browse the repository at this point in the history 
On May 11, builds (e.g. https://github.com/spinnaker/clouddriver/runs/6395450456?check_suite_focus=true, https://github.com/spinnaker/clouddriver/runs/6396984248?check_suite_focus=true and https://github.com/spinnaker/clouddriver/runs/6396922814?check_suite_focus=true) started failing with e.g.:

> Task :clouddriver-titus:compileJava
      if (!com.google.protobuf.GeneratedMessageV3.isStringEmpty(accountId_)) {
                                                 ^
  symbol:   method isStringEmpty(Object)
  location: class GeneratedMessageV3
/home/runner/work/clouddriver/clouddriver/clouddriver-titus/build/generated/source/proto/main/java/com/netflix/titus/TitusVpcApi.java:413: error: cannot find symbol

According to https://repo.maven.apache.org/maven2/com/google/protobuf/protobuf-java/,
com.google.protobuf:3.21.0-rc-1 arrived on May 11, but pinning to the latest version
before that (3.20.1) doesn't work either.  Neither do 3.19.x nor 3.18.x.  3.17.3 is the
newest version that works.

(cherry picked from commit 10a8d09)

Co-authored-by: David Byron <82477955+dbyron-sf@users.noreply.github.com>
  • Loading branch information
@mergify @dbyron-sf
mergify[bot] and dbyron-sf authored May 17, 2022
1 parent ccf7534 commit a06ae3c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion clouddriver-titus/clouddriver-titus.gradle
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apply plugin: "com.google.protobuf"

ext {
protobufVersion = '[3.2.0,)'
protobufVersion = '[3.2.0,3.17.3]'
grpcVersion = '1.37.1'
}

Expand Down

0 comments on commit a06ae3c

Please sign in to comment.