Fixed a bug where backslashes in paths could show up in RST files #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/master: MAINT: Fix CIs (sphinx-gallery#1046) Reorder paragraphs in the minigallery documentation (sphinx-gallery#1048)
|
Merged latest |
|
Thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the gallery directory path has an OS path separator in it, the separators need to be sanitized (on Windows) to be all forward slashes before the path is inserted into RST files. This PR fixes a missing sanitization.
For comparison, here is another place in the codebase where the sanitization is performed:
sphinx-gallery/sphinx_gallery/backreferences.py
Lines 299 to 300 in 15ec1f9