Bool value for spf13 #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken by commit 463bdc8 ("Adding Type() method to the values.") which added the method to the interface but did not update the custom types in unit tests. Signed-off-by: Filipe Brandenburger <filbranden@google.com>
This is consistent with Go's native flag parsing module and can be used to implement custom boolean/tri-state flags. Signed-off-by: Filipe Brandenburger <filbranden@google.com>
…rue/false/maybe) Signed-off-by: Filipe Brandenburger <filbranden@google.com>
|
@spf13 Ping? |
|
Discussed this offline with Steve and he's happy with the patch, merging it now. |
infalmo
pushed a commit
to infalmo/pflag
that referenced
this pull request
Sep 28, 2020
infalmo
pushed a commit
to infalmo/pflag
that referenced
this pull request
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the counterpart to ogier#13 for the spf13/pflag repository, it fixes issue ogier#11 by implementing IsBoolFlag() same as Go's native pflag module.
This PR also includes #2 since I wanted to make sure the test cases would pass here. The commit SHA1 is the same, so merging one after the other should not cause any problems (and merging this one should make #2 obsolete) but if you wish I don't mind rebasing this one if you want to commit that one first...
cc'ing @jbeda with whom I discussed this issue, who also opened ogier#11.
Cheers,
Filipe