Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging of parameters #2470

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Improve logging of parameters #2470

merged 2 commits into from
Mar 24, 2024

Conversation

Adel-Moumen
Copy link
Collaborator

@Adel-Moumen Adel-Moumen commented Mar 21, 2024 •
edited
Loading

What does this PR do?

This PR aims at modifying the print statement on the total number of trainable parameters. Now you have much more information. Example:

speechbrain.core - ASR Model Statistics:
* Total Number of Trainable Parameters: 2.1M
* Total Number of Parameters: 317.6M
* Trainable Parameters represent 0.6704% of the total size.

You can get the breakdown of trainable parameters, total size of the model, and the percentage of trainable parameters with respect to total size. This makes it easier to read and more meaningful to the end user.

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@Adel-Moumen Adel-Moumen self-assigned this Mar 21, 2024
@Adel-Moumen Adel-Moumen added the enhancement New feature or request label Mar 21, 2024
pplantinga
pplantinga approved these changes Mar 24, 2024
View reviewed changes
Copy link
Collaborator

@pplantinga pplantinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice change, thanks @Adel-Moumen !

@Adel-Moumen Adel-Moumen merged commit 312bcf3 into speechbrain:develop Mar 24, 2024
5 checks passed
pchampio pushed a commit to pchampio/speechbrain that referenced this pull request Apr 17, 2024
@Adel-Moumen @pchampio
Improve logging of parameters (speechbrain#2470)
c24c187 
* pre commit

* Update core.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pplantinga pplantinga pplantinga approved these changes

@TParcollet TParcollet Awaiting requested review from TParcollet

Assignees

@Adel-Moumen Adel-Moumen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Adel-Moumen @pplantinga