Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update text.py #2336

Merged
merged 1 commit into from
Jan 21, 2024
Merged

Update text.py #2336

merged 1 commit into from
Jan 21, 2024

Conversation

ppisljar
Copy link
Contributor

@ppisljar ppisljar commented Jan 14, 2024 •
edited
Loading

fixes error: TypeError: Pretrainer.load_collected() got an unexpected keyword argument 'device'

  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@ppisljar
Update text.py
d560c16 
fixes error: TypeError: Pretrainer.load_collected() got an unexpected keyword argument 'device'
Adel-Moumen
Adel-Moumen approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@Adel-Moumen Adel-Moumen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adel-Moumen
Copy link
Collaborator

Thanks @ppisljar :-)

@Adel-Moumen Adel-Moumen merged commit ee2523f into speechbrain:develop Jan 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adel-Moumen Adel-Moumen Adel-Moumen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppisljar @Adel-Moumen