Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added german_cleaners #1642

Merged
merged 4 commits into from
Nov 22, 2022
Merged

Added german_cleaners #1642

merged 4 commits into from
Nov 22, 2022

Conversation

padmalcom
Copy link
Contributor

I added a german cleaner to avoid lowercasing texts.

@mravanelli mravanelli requested a review from BenoitWang November 2, 2022 15:57
@BenoitWang
Copy link
Collaborator

Hi @padmalcom thank you for the pr, could you please explain why here you try to avoid lowercasing for German? And in German are abbreviations used? Is this cleaner general for German or for certain datasets? (Excuse that I don't speak German.) Thank you.

@padmalcom
Copy link
Contributor Author

Hi @BenoitWang, sure! In German nouns start with a capital letter, verbs, adverbs etc. don't. E.g. "Zahlen" (numbers) and "zahlen" (to pay) can have different meanings, so cases are important. Abbreviations are used, yes. Since the dataset I use, is generated from mp3s and text is extracted via speech-to-text models and fixed by a punctuation model, I'm pretty sure that it does not contain abbreviations. The cleaner will work for every dataset.

@BenoitWang
Copy link
Collaborator

Ok I see. Please finish the tests (some simple linter issues). You are also welcome to create a list of german abbreviations if you've got time.

Copy link
Collaborator

@BenoitWang BenoitWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good.

@padmalcom
Copy link
Contributor Author

Sorry what ist the issue Here?

@BenoitWang BenoitWang merged commit 5063efb into speechbrain:develop Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants