Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documented min python version to 3.7 #1595

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

asumagic
Copy link
Collaborator

@asumagic asumagic commented Oct 5, 2022

Fixes #1593: The minimal Python version SB targets is 3.7, not 3.8.

Those were the only mentions to 3.8 being the minimal requirement I could find in the codebase.

FWIW,

  • readthedocs is configured for 3.8. I just noticed that TParcollet edited the version there from 3.9 to 3.8 a while back.
  • pre-commit checks are run on the CI using 3.8.
  • the PyPI publish step is run using 3.8.

Should anything be done about these?

@anautsch
Copy link
Collaborator

anautsch commented Oct 5, 2022

Below are some comments to respond more broadly about your well brought up concerns (no idea at the moment what would be a good 'instruction').

  • We run github tests on python 3.7; 3.8 & 3.9.
  • readthedocs needs to be configured to one Python version. 3.8 (to me) appears as the best bridge between these versions—yet, at some point, python 3.11 is beyond release candidate and 3.7-3.10 will become deprecated - after a period for security updates, the whole pytorch ecology will have no chance but to migrate to the new space - end of life: 3.7 (27 Jun 2023); 3.8 (14 Oct 2024); 3.9 (05 Oct 2025)—when 3.8 turns deprecated, why even bother to adopt python 3.10 ? ;-)
  • likewise, pre-commit checks need to operate on one specific version—the github checks cover 3.7 to 3.9 versions (if there'd be an issue, it comes clear there—haven't seen that happening thus far though)
  • pypi step also needs to use a specific version, I'd assume—3.8 seems a reasonable choice for the time being

You have good points—pretty good catches !

@anautsch anautsch merged commit 8c05fc1 into speechbrain:develop Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conflicting documentation on supported Python versions
2 participants