Log handled errors to warning #1926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfechner
changed the title
Ruwann
reviewed
May 19, 2024
|
@Ruwann kind reminder to merge 🙏 🙇 |
RobbeSneyders
pushed a commit
that referenced
this pull request
May 27, 2024
Fixes #1925. Changes proposed in this pull request: - Log handled errors to `warning` instead of `error`. - Log validation errors to `info` because the intent of the log lines in informational. The error is handled by raising a new error. --------- Co-authored-by: Alex Fechner <alex.fechner@stryker.com>
| @@ -68,7 +68,7 @@ def _validate(self, body: t.Any) -> t.Optional[dict]: | |||
| return self._validator.validate(body) | |||
| except ValidationError as exception: | |||
| error_path_msg = format_error_with_path(exception=exception) | |||
| logger.error( | |||
| logger.info( | |||
There was a problem hiding this comment.
It would be nice to configure this, as I'd quite like it as a warning; but not an error, and it's clear to me from this that many people may have different use-cases. I Know I can redirect a log-stream.
Ruwann
pushed a commit
that referenced
this pull request
May 28, 2024
…#1926. (#1935) @RobbeSneyders, @Ruwann sorry for this, it seems like I've sneaked in a duplicate log statement in PR #1926 🙇♂️ --------- Co-authored-by: Alex Fechner <alex.fechner@stryker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1925.
Changes proposed in this pull request:
warninginstead oferror.infobecause the intent of the log lines in informational. The error is handled by raising a new error.