ext: load C extension files from non-native gems via "require" #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and not "require relative" Fixes #2300
flavorjones
added
topic/installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
As reported in #2300, we should be loading the C extension relying on
requireand$LOAD_PATHand not usingrequire_relative.Have you included adequate test coverage?
No. This is a bit challenging to test, as we'd have to modify the gem installation (and delete the
nokogiri.sofiles present under "lib/nokogiri"), and the regression value is pretty low (especially given the verbose comment in this PR).That said, this change has adequate test coverage already in the
gem-installCI pipeline, to ensure we don't break unmodified installations.Does this change affect the behavior of either the C or the Java implementations?
No.