Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: openapi response schema #960

Merged
merged 6 commits into from
Sep 24, 2024
Merged

feat: openapi response schema #960

merged 6 commits into from
Sep 24, 2024

Conversation

VishnuSanal
Copy link
Contributor

Description

This PR fixes #930

Summary

This PR does add the openapi response schema

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

@vercel Vercel
Copy link

vercel bot commented Sep 14, 2024

@VishnuSanal is attempting to deploy a commit to the sparckles Team on Vercel.

A member of the Team first needs to authorize it.

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Sep 14, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #960 will not alter performance

Comparing VishnuSanal:openapi-response-schema (488f84d) with main (e6872af)

Summary

✅ 115 untouched benchmarks

🆕 1 new benchmarks

Benchmarks breakdown

Benchmark main VishnuSanal:openapi-response-schema Change
🆕 test_openapi_response_body N/A 6 ms N/A

sansyrox
sansyrox reviewed Sep 15, 2024
View reviewed changes
robyn/types.py Outdated Show resolved Hide resolved
@VishnuSanal
Copy link
Contributor Author

VishnuSanal commented Sep 23, 2024 •
edited
Loading

  • docs

@VishnuSanal
Copy link
Contributor Author

@sansyrox updated the docs, PTAL.

@vercel Vercel
Copy link

vercel bot commented Sep 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 11:14am

sansyrox
sansyrox approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍 ❇️

@sansyrox sansyrox merged commit 399f5b1 into sparckles:main Sep 24, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sansyrox sansyrox sansyrox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response schema missing in openapi docs
2 participants
@VishnuSanal @sansyrox