Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correction of "Closed" to "closed" in temporary ws test fix #1078

Merged
merged 1 commit into from
Dec 15, 2024
Merged

fix: correction of "Closed" to "closed" in temporary ws test fix #1078

merged 1 commit into from
Dec 15, 2024

Conversation

dave42w
Copy link
Contributor

@dave42w dave42w commented Dec 10, 2024

Description

This PR properly fixes the issue with was integration tests

Summary

This PR does....

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

@vercel Vercel
Copy link

vercel bot commented Dec 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 6:39pm

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Dec 10, 2024

CodSpeed Performance Report

Merging #1078 will not alter performance

Comparing dave42w:ws2 (5beffa4) with main (f86dbd5)

Summary

✅ 146 untouched benchmarks

sansyrox
sansyrox approved these changes Dec 15, 2024
View reviewed changes
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dave42w 😄

@sansyrox sansyrox merged commit d3e6766 into sparckles:main Dec 15, 2024
54 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sansyrox sansyrox sansyrox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dave42w @sansyrox