Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: integrate uv in the ci pipelines and the docs #1040

Merged
merged 13 commits into from
Nov 22, 2024

Conversation

Mr-Sunglasses
Copy link
Contributor

@Mr-Sunglasses Mr-Sunglasses commented Nov 19, 2024

Description

This PR fixes #1020

Summary

This PR add the uv package manager to CI pipeline. This will help in increasing the CI speed.

PR Checklist

Please ensure that:

  • The PR contains a descriptive title
  • The PR contains a descriptive summary of the changes
  • You build and test your changes before submitting a PR.
  • You have added relevant documentation
  • You have added relevant tests. We prefer integration tests wherever possible

Pre-Commit Instructions:

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
robyn ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 4:05pm

@sansyrox
Copy link
Member

@Mr-Sunglasses , is this PR complete?

@Mr-Sunglasses
Copy link
Contributor Author

Mr-Sunglasses commented Nov 21, 2024

@Mr-Sunglasses , is this PR complete?

@sansyrox Yes this PR completed.

Copy link

codspeed-hq bot commented Nov 21, 2024

CodSpeed Performance Report

Merging #1040 will not alter performance

Comparing Mr-Sunglasses:migrate-to-uv (a20da46) with main (3f2e79a)

Summary

✅ 146 untouched benchmarks

@Mr-Sunglasses Mr-Sunglasses changed the title [WIP]: Feat: integrate uv in the ci pipelines and the docs Feat: integrate uv in the ci pipelines and the docs Nov 21, 2024
Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mr-Sunglasses 👋

Welcome back to the repo 😄 Just one question before we can merge.

Comment on lines +12 to +13
env:
UV_SYSTEM_PYTHON: 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one q - why is this needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref. https://docs.astral.sh/uv/guides/integration/github/#using-uv-pip

If using the uv pip interface instead of the uv project interface, uv requires a virtual environment by default. To allow installing packages into the system environment, use the --system flag on all uv invocations or set the UV_SYSTEM_PYTHON variable.

The UV_SYSTEM_PYTHON variable can be defined in at different scopes.

Opt-in for the entire workflow by defining it at the top level:

Comment on lines +8 to +10
env:
UV_SYSTEM_PYTHON: 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same q

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref. https://docs.astral.sh/uv/guides/integration/github/#using-uv-pip

If using the uv pip interface instead of the uv project interface, uv requires a virtual environment by default. To allow installing packages into the system environment, use the --system flag on all uv invocations or set the UV_SYSTEM_PYTHON variable.

The UV_SYSTEM_PYTHON variable can be defined in at different scopes.

Opt-in for the entire workflow by defining it at the top level:

Copy link
Member

@sansyrox sansyrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @Mr-Sunglasses

@sansyrox sansyrox merged commit 9a95611 into sparckles:main Nov 22, 2024
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

integrate uv in the ci pipelines and the docs
2 participants