xkeyboard-config: add xkbdata provider #45571
Conversation
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
spackbot-app
bot
added
core
This comment was marked as outdated.
This comment was marked as outdated.
|
Thanks for pointing this out! Will also be relevant is other PRs. I'll go through and make sure it's properly applied here and elsewhere. |
…@bernhardkaindl Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
There was a problem hiding this comment.
@teaguesterling Great, PR is updated as expected.
While I re-requested @alalazo's review, he "changes-requested" flag can only be cleared by him giving an approval before this PR can be merged. As this PR is updated to what @alalazo specified, you might consider if you like to open a new PR with the same branch and then close this PR, but I guess it's fine to take the weekend and look for @alalazo's review on Monday or so if you agree.
|
@bernhardkaindl ah right! Sorry for the noise. No urgency here. Was just making sure I haven't left anything dangling. |
|
This was in preparation for the turbovnc package, but that's a good point to actually make use of the virtual now. I'll update. |
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
|
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
The
xkbdatapackage and thexkeyboard-configpackage end up overlapping in namespaces and can't be used together. Thexkeyboard-configpackage provides more functionality than thexkbdataand appears to be a superset of it. Notably, dependencies in #44722 would not build with justxkbdataand whenxkeyboard-configwas provided the view failed with overlapping paths. When addingxkeyboard-dataas a provider, everything "just works."