Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complex interactions with throwing items into disposals (Maybe overly so...) #33957

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Complex interactions with throwing items into disposals (Maybe overly so...) #33957

wants to merge 4 commits into from
+125 −27

Conversation

beck-thompson
Copy link
Contributor

About the PR

Overview:
1.) Certain items are now "dunkable" and have an easier time being thrown into item containers (disposals). This includes basketballs and trash!
2.) If you are blind you always miss throwing items into the trash.
3.) If you are partly blind (Welding blindness), you have a lower chance of throwing items in depending on how blind you are.
4.) Clumsy people are very unlikely to throw stuff in the trash.

Why / Balance

I think small interactions like this are a lot of fun and are really core to what ss14 is. I also was going to make it less likely to throw stuff in depending on how far away you were, but this ended up just not being as fun! I'm also open to upping the default chance (25%) but I'll leave that up to someone else.

Technical details

Just added some events to ThrowInsertContainerSystem.cs and hooked other systems to listen for them!

Media

2024-12-18.21-53-29.mp4

(Excuse the massive lag)

Requirements

Breaking changes

Changelog

🆑 Beck Thompson

  • add: More interactions when throwing items into disposals!

@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. size/M Denotes a PR that changes 100-999 lines. labels Dec 19, 2024
@ArtisticRoomba
Copy link
Contributor

finally, now I can actually drain root beer cans from across the room without it being a Missed! 90% of the time

@beck-thompson
Copy link
Contributor Author

also if a maintainer wants me to un-touch the whitespace issues I'll do it. I'll make another PR to remove them later because its really brutal

@ScarKy0 ScarKy0 added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Cleanup Type: Code clean-up, without being a full refactor or feature D2: Medium Difficulty: A good amount of codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: General Interactions Area: General in-game interactions that don't relate to another area. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: General Interactions Area: General in-game interactions that don't relate to another area. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Cleanup Type: Code clean-up, without being a full refactor or feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@beck-thompson @ArtisticRoomba @ScarKy0