Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable meta-atlas for big rare RSIs #33643

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable meta-atlas for big rare RSIs #33643

wants to merge 1 commit into from
+21 −10

Conversation

PJB3005
Copy link
Member

@PJB3005 PJB3005 commented Nov 29, 2024

Gods and board games

needs space-wizards/RobustToolbox#5544 but engine won't throw a fit without it.

@PJB3005
Disable meta-atlas for big rare RSIs
a286699 
Gods and board games

needs space-wizards/RobustToolbox#5544 but engine won't throw a fit without it.
@PJB3005 PJB3005 added the T: Performance Type: Performance impacting changes or bugs label Nov 29, 2024
@github-actions github-actions bot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. size/M Denotes a PR that changes 100-999 lines. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Nov 29, 2024
@ScarKy0 ScarKy0 added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Engine PR Merged Status: Requires an existing Robust Toolbox PR to be merged first. D3: Low Difficulty: Some codebase knowledge required. S: Needs Review Status: Requires additional reviews before being fully accepted A: Core Tech Area: Underlying core tech for the game and the Github repository. labels Nov 29, 2024
PJB3005
PJB3005 commented Dec 17, 2024
View reviewed changes
Copy link
Member Author

@PJB3005 PJB3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code is CRINGE (test review)

PJB3005
PJB3005 commented Dec 17, 2024
View reviewed changes
Copy link
Member Author

@PJB3005 PJB3005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Among us!!!

@AverageNotDoingAnythingEnjoyer
Copy link
Contributor

It's been merged, just in case

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. Changes: No C# Changes: Requires no C# knowledge to review or fix this item. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Needs Engine PR Merged Status: Requires an existing Robust Toolbox PR to be merged first. S: Needs Review Status: Requires additional reviews before being fully accepted size/M Denotes a PR that changes 100-999 lines. T: Performance Type: Performance impacting changes or bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PJB3005 @AverageNotDoingAnythingEnjoyer @ScarKy0