Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Inhand Sprites MegaIssue™ #33386

Open
TiniestShark opened this issue Nov 18, 2024 · 7 comments
Open

Missing Inhand Sprites MegaIssue™ #33386

TiniestShark opened this issue Nov 18, 2024 · 7 comments
Labels
A: Art Area: Art with no implications for other areas. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.

Comments

@TiniestShark
Copy link
Contributor

TiniestShark commented Nov 18, 2024 •
edited
Loading

Description

There's many items in the game currently lacking any form of Inhand sprites and just appear invisible when held. While not exactly a high priority, fixing and adding inhands to many of these will help with general immersion and visibility.

This is by no means entirely comprehensive (I am one human being) and if there's any I missed, please let me know. Some items were grouped together that could be solved with a generic inhand for their particular category. (I'm also not including items there are already open or already merged PRs for)

I'll update this as PRs are added, Food/Drinks/Plants will be their own issue at some point (Just assume its all of them)

Item Groups:

Clothing:

Dishes/Utencils:

Instruments:

Materials:

Medical:

Plushies/Toys:

Tools/Devices:

Trash/Scrap:

Syndicate/Criminal Items:

Weapons/Ammo:

Other:
@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Nov 18, 2024
@muburu muburu mentioned this issue Nov 18, 2024
Merged
2 tasks
@Boaz1111 Boaz1111 added P3: Standard Priority: Default priority for repository items. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. A: General Interactions Area: General in-game interactions that don't relate to another area. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. A: Art Area: Art with no implications for other areas. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. A: General Interactions Area: General in-game interactions that don't relate to another area. labels Nov 18, 2024
@TiniestShark TiniestShark mentioned this issue Nov 20, 2024
Merged
2 tasks
@Errant-4
Copy link
Member

Please add #31788

@TiniestShark
Copy link
Contributor Author

Please add #31788

Added. Muburu's working on them currently I believe but still useful as a reference point.

@onesch onesch mentioned this issue Nov 22, 2024
Merged
2 tasks
@onesch
Copy link
Contributor

onesch commented Nov 23, 2024

Hello, should I create a pull request for each element separately or take some ready-made bundle and create a pull request?

@Flareguy
Copy link
Contributor

Hello, should I create a pull request for each element separately or take some ready-made bundle and create a pull request?

It's up to you. Considering inhands are pretty small and specific in nature, I would say it's fine (and even encouraged) to do several at once, especially if they are related in some way. I definitely wouldn't take on the whole list at once or anything, though; The bigger your PR, the more likely it is that something will need to be changed, or that someone else will be working on it.

@Flareguy
Copy link
Contributor

Flareguy commented Nov 23, 2024 •
edited
Loading

Also, to anyone looking at this: I would highly recommend looking for sprites from other SS13 codebases to see if they have suitable inhands before you make them. A lot of the time, SS14 just seems to have.... not ported the original inhand sprites, for no discernible reason. The health analyzer and bola come to mind here.

You can use scrubby iconsearch to take a quick search for what you are looking for. Just be mindful that you'll need to actually find what commit the sprite is in yourself, alongside ensuring that the sprite fits the artstyle.

@onesch onesch mentioned this issue Nov 24, 2024
Merged
2 tasks
@Theosist
Copy link

I started making in-hand versions for the various book assets. Also, while I was looking around the game for bedsheets, I noticed that there seems to already be bedsheets sprites (and that red/pink is inconsistent when worn).
I’m not experienced with spriting, so if anyone wants to help me, especially with the not-art stuff, I’m on discord.
IMG_7694

@muburu muburu mentioned this issue Dec 1, 2024
Open
2 tasks
@onesch onesch mentioned this issue Dec 2, 2024
Open
2 tasks
@onesch
Copy link
Contributor

onesch commented Dec 21, 2024

@TiniestShark
I added sprites for spray_painter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: Art Area: Art with no implications for other areas. DB: Beginner Friendly Difficulty: Great for beginners. Unambiguous in scope, and explains how to achieve the result. P3: Standard Priority: Default priority for repository items. S: Requires Content PR Status: Requires a change to SS14, for which there is no open PR currently. T: Visual Change Type: Deals with changes to art, sprites or other visuals in the game.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Errant-4 @Flareguy @onesch @Boaz1111 @TiniestShark @Theosist