Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port BUIs to use component states #27042

Open
metalgearsloth opened this issue Apr 17, 2024 · 0 comments
Open

Port BUIs to use component states #27042

metalgearsloth opened this issue Apr 17, 2024 · 0 comments
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Refactor Type: Refactor of notable amount of codebase T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces

Comments

@metalgearsloth
Copy link
Contributor

I might've made an issue for this but uhh yeah.

If you want predicted UI opening to not feel awful then they should use comp states which are easier to use anyway.

The general flow is:

  • Move the existing BUI state to comp networking.
  • Find attached system but if doesn't exist make a UI controller or the likes.
  • Sub to AfterAutoHandleState with TryGetOpenUi.
  • Call BUI update method to indicate component has changed.

Same thing when Open is called then you just call whatever update method.
@metalgearsloth metalgearsloth added P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. D2: Medium Difficulty: A good amount of codebase knowledge required. labels Apr 17, 2024
@github-actions github-actions bot added the S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. label Apr 17, 2024
@eoineoineoin eoineoineoin added T: Refactor Type: Refactor of notable amount of codebase T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces A: Core Tech Area: Underlying core tech for the game and the Github repository. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: Core Tech Area: Underlying core tech for the game and the Github repository. D2: Medium Difficulty: A good amount of codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. T: Refactor Type: Refactor of notable amount of codebase T: UI / UX Improvement Type: UI and player facing interactive graphical interfaces
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eoineoineoin @metalgearsloth