Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rename Name to Title #818

Conversation

illfixit
Copy link
Collaborator

@illfixit illfixit commented Sep 9, 2024

What issues does this PR close?
closes #800 Attribute names are inconsistent on asset creation (EDC UI) vs the data catalog page (AP)

Only cosmetic (no form control name) changes in this PR to avoid compat issues and BE refactoring

Create Data Offer Page

image

Create New Asset Dialog

image

Checklist

Preview Give feedback

@illfixit illfixit marked this pull request as ready for review September 9, 2024 09:40
…t-creation-edc-ui-vs-the-data-catalog-page-ap
@illfixit illfixit enabled auto-merge (squash) September 11, 2024 11:48
…t-creation-edc-ui-vs-the-data-catalog-page-ap
@illfixit illfixit requested a review from kamilczaja September 11, 2024 11:55
Copy link
Collaborator

@kamilczaja kamilczaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@illfixit illfixit merged commit b8a5bc6 into main Sep 11, 2024
11 checks passed
@illfixit illfixit deleted the 800-attribute-names-are-inconsistent-on-asset-creation-edc-ui-vs-the-data-catalog-page-ap branch September 11, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute names are inconsistent on asset creation (EDC UI) vs the data catalog page (AP)
2 participants