[MRG] move setup.cfg into pyproject.toml #2097

luizirber · 2022-06-23T14:49:28Z

Prompted by https://twitter.com/HenrySchreiner3/status/1539245259670138882

Open questions/TODO:

can we move to setuptools > 60? Seems like it was an issue on [MRG] pin setuptools < 60 #1879 with conda
we can list all authors now! but need to add emails, as well as the others listed in the command run in [MRG] Updating citation and codemeta #837 (comment)
update PR template to point to adding your name to the author list if it is your first contribution
this is not supported, but I tried putting ORCID as a key in the author list and... it worked. Might be a good canonical place to put it?

codecov · 2022-06-23T14:58:47Z

Codecov Report

Merging #2097 (cb2e2d7) into latest (a2da84f) will increase coverage by 7.38%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           latest    #2097      +/-   ##
==========================================
+ Coverage   84.30%   91.69%   +7.38%     
==========================================
  Files         130       99      -31     
  Lines       15280    11004    -4276     
  Branches     2171     2171              
==========================================
- Hits        12882    10090    -2792     
+ Misses       2095      611    -1484     
  Partials      303      303

Flag	Coverage Δ
python	`91.69% <ø> (ø)`
rust	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/core/src/index/sbt/mhbt.rs
src/core/src/cmd.rs
src/core/src/signature.rs
src/core/src/sketch/minhash.rs
src/core/src/ffi/minhash.rs
src/core/src/index/linear.rs
src/core/src/ffi/mod.rs
src/core/tests/test.rs
src/core/tests/minhash.rs
src/core/src/storage.rs
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2da84f...cb2e2d7. Read the comment docs.

luizirber · 2022-06-25T00:49:50Z

between #837 and #1361 I think I got most ORCID IDs added. I also found out that email is not required and we can list maintainers in the same format (ref), so I added this to pyproject.toml.

If the PR reviewer can run git shortlog --summary --numbered -e and check if I got authors right, that would be helpful =]

Question: should we ping people to check if their agree with 1) email being shared, 2) ORCID is correct (or create one if missing)?

luizirber · 2022-06-26T00:40:22Z

Turns out emails are not mandatory, so might as well remove them. I did keep them for the maintainers field, I think it makes sense to have some way of contacting the project, without potentially generating spam to all authors.

pyproject.toml

luizirber · 2022-06-26T16:12:38Z

I asked on Python discuss about adding extra fields (like orcid) in the authors/maintainers list.

pyproject.toml

luizirber · 2022-07-09T01:06:11Z

I asked on Python discuss about adding extra fields (like orcid) in the authors/maintainers list.

Consensus seems to be "it won't break, but it is probably not a good idea at the moment".

I'm inclined to leave the orcid field for now (since they were already collected 🙃 ), and in a future PR make the authors field dynamic and load it from other source (like CITATION.cff or the zenodo config)

Co-authored-by: ccbaumler <63077899+ccbaumler@users.noreply.github.com>

luizirber · 2022-07-09T01:24:53Z

Ready for review and merge @sourmash-bio/devs

luizirber commented Jun 26, 2022

View reviewed changes