nix: reorganizing #52273
nix: reorganizing #52273
Conversation
dev/nix/ctags.nix
Outdated
| postFixup = (oldAttrs.postFixup or "") + '' | ||
| ln -s $out/bin/ctags $out/bin/universal-ctags | ||
| ''; | ||
| })) |
There was a problem hiding this comment.
I was thinking instead of overriding stuff, it might be clearer if we just copy the original derivation and make it do exactly what we want
There was a problem hiding this comment.
Yea that seems doable tbh, been on the fence about this for some time
| }; | ||
| }) | ||
| nodePackages.typescript | ||
| nodejs-16_x.pkgs.pnpm |
There was a problem hiding this comment.
This works because of overlay?
| , hostPlatform | ||
| , lib | ||
| , writeShellScriptBin | ||
| }: |
There was a problem hiding this comment.
Does nix-shell auto add these args, or is it time to stop calling this shell.nix?
There was a problem hiding this comment.
Its done by pkgs.callPackage if youre referring to what happens at runtime
There was a problem hiding this comment.
I was refering to old school running of nix-shell instead of nix develop. IE it would be cool to move this file into dev/nix to avoid yet another file in our top-level dir.
There was a problem hiding this comment.
ah I think I can make this in particular backwards compat, but theres also the issue of us providing additional stuff via overlays etc that arent defined in here, so theres already going to be some discrepancies
There was a problem hiding this comment.
yeah I don't think we need the backcompat. The users of it are you and I. I use it via nix develop personally.
|
tested on both nix-darwin and nixos and it worked. cool stuff |
Strum355
force-pushed
the
nsc/nix-shuffle2
branch
from
0c966b1 to
6c68c9c
Compare
Re-organizing a couple of things to make the individual files nicer, consolidated some things in ctags.nix, extracted forEachSystem stuff to flake.nix instead of the individual files, overlay for our specific nodejs requirements, some more comments to stuff ## Test plan N/A, nix stuff
Re-organizing a couple of things to make the individual files nicer, consolidated some things in ctags.nix, extracted forEachSystem stuff to flake.nix instead of the individual files, overlay for our specific nodejs requirements, some more comments to stuff
Test plan
N/A, nix stuff