This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
bazel: make work on nixos ❇️ #51154
Merged
bazel: make work on nixos ❇️ #51154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strum355
force-pushed
the
nsc/bazel-on-nixos
branch
2 times, most recently
from
877f1ae to
b809970
Compare
jhchabran
approved these changes
Apr 27, 2023
| @@ -74,19 +74,50 @@ http_archive( | |||
| urls = ["https://github.com/bazelbuild/rules_rust/releases/download/0.19.0/rules_rust-v0.19.0.tar.gz"], | |||
| ) | |||
|
|
|||
| http_archive( | |||
There was a problem hiding this comment.
Can we move this into dev/nix.bzl ?
You can basically take all of this code, and wrap it under a macro:
# dev/nix.bzl
def nix_deps():
http_archive(...)
# WORKSPACE
load("//dev:nix.bzl", "nix_deps")
nix_deps()
This way we avoid lengthening this file further 😊
There was a problem hiding this comment.
Done as best I could here, it seems like rules_nixpkgs_dependencies must be called before any of the other symbols are loaded, so some stuff remains in WORKSPACE
Strum355
force-pushed
the
nsc/bazel-on-nixos
branch
from
b809970 to
c92076f
Compare
|
Will need to rebase this now that https://github.com/sourcegraph/sourcegraph/pull/49884 landed, job for tomorrow |
Strum355
force-pushed
the
nsc/bazel-on-nixos
branch
from
c92076f to
916f03f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some sprinkling of special sauce for the NixOS (and nix shell) users in the house. Much care has been taken so that there should be no interference with anyone running bazel on a non-nixos machine, and that it also works as (mostly) expected for nix shell users on macos.
Test plan
Ran main dry-run, all green, so it shouldnt interfere with anyone on a non-nixos machine