notebooks: remove elm compute component #45360
Conversation
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff b9a2844...972a261.
|
| @@ -6,8 +6,7 @@ func validateNotebookBlock(block NotebookBlock) error { | |||
| if block.Type != NotebookQueryBlockType && | |||
| block.Type != NotebookMarkdownBlockType && | |||
| block.Type != NotebookFileBlockType && | |||
| block.Type != NotebookSymbolBlockType && | |||
There was a problem hiding this comment.
what do we do about existing notebooks with these blocks? Would they fail to save?
There was a problem hiding this comment.
I've changed backend.ts to delete any invalid blocks before saving.
There was a problem hiding this comment.
I debated where to do this (backend? frontend? on fetch? on save?) and decided this was the easiest way.
There was a problem hiding this comment.
works for me as long as nothing breaks - doesn't sound like it :)
There was a problem hiding this comment.
It's working for me at least from what I've tested (test cases in the description above)
Good catch, thanks! This is because I removed the |
|
Nice, thank you @limitedmage! |
This removes all code related with the Notebook compute component, including the backend API, Elm build, etc.
Test plan