This repository has been archived by the owner on Sep 30, 2024. It is now read-only.
compute: additions to run standalone component #32701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvantonder
force-pushed
the
rvt/compute-workshop
branch
5 times, most recently
from
8ece281 to
a63a538
Compare
rvantonder
force-pushed
the
rvt/compute-workshop
branch
from
a63a538 to
5edee82
Compare
rvantonder
commented
Mar 23, 2022
Comment on lines
+1
to
+2
| /* eslint-disable unicorn/no-abusive-eslint-disable */ | ||
| /* eslint-disable */ |
There was a problem hiding this comment.
Yeah I don't care. I tried .eslintignore but it doesn't listen so now I'm doing this. ports.js is only ever executed in the standalone/dev setup, never by any Sourcegraph app logic.
novoselrok
approved these changes
Mar 24, 2022
camdencheek
approved these changes
Mar 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds files to run the compute block standalone, and dev instructions. It's useful for development, and more so, for upcoming workshop. It may not necessarily be ultra-long-lived, but it will be long-lived enough (at least one to 3 months) that I think it's worth committing to the main branch so people can get started hacking/developing quickly.
Test plan
Development setup for working with standalone component, no functionality.