Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

Revert Mocha JUnit reporter usage #31626

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Revert Mocha JUnit reporter usage #31626

merged 1 commit into from
Feb 22, 2022

Conversation

umpox
Copy link
Contributor

@umpox umpox commented Feb 22, 2022 •
edited
Loading

Description

We started generated JUnit reports through mocha-junit-reporter in this PR: https://github.com/sourcegraph/sourcegraph/pull/28262

This library appears to swallow the output of the CI command, so errors become very difficult to debug

This PR reverts the test commands back to their state before this reporter was added

Issue to fix/re-enable: https://github.com/sourcegraph/sourcegraph/issues/31627

Test plan

  1. Break some Mocha tests (e.g. e2e or qa tests)
  2. Notice that the error is correctly surfaced in the command output

@cla-bot cla-bot bot added the cla-signed label Feb 22, 2022
@github-actions github-actions bot added the frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew. label Feb 22, 2022
@umpox umpox mentioned this pull request Feb 22, 2022
Open
@umpox umpox requested review from jhchabran and mrnugget February 22, 2022 14:13
@umpox umpox marked this pull request as ready for review February 22, 2022 14:13
jhchabran
jhchabran reviewed Feb 22, 2022
View reviewed changes
Copy link
Contributor

@jhchabran jhchabran left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Don't we want to do the same with the QA tests as well? Or are they not swallowing errors too?

@umpox
Copy link
Contributor Author

umpox commented Feb 22, 2022

@jhchabran This includes QA too!

dev/ci/integration/qa/test.sh

@umpox umpox merged commit e1440c4 into main Feb 22, 2022
@umpox umpox deleted the tr/revert-mocha-junit branch February 22, 2022 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jhchabran jhchabran jhchabran left review comments

@valerybugakov valerybugakov valerybugakov approved these changes

@mrnugget mrnugget Awaiting requested review from mrnugget

Assignees
No one assigned
Labels
cla-signed frontend-platform Issues related to our frontend platform, owned collectively by our frontend crew.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@umpox @jhchabran @valerybugakov