symbols: replace pcre lib with a Go function (fixup 2) #25421

chrismwendt · 2021-09-28T01:31:45Z

Third time's the charm.

The original PR symbols: replace pcre lib with a Go function #25374 didn't use a musl compiler so the executable wouldn't even start in prod on Alpine
Attempt 2 symbols: replace pcre lib with a Go function (fixup) #25401 seemed to fix the problem by disabling cgo but crashed at runtime
And now this PR uses a musl compiler, re-enables cgo, and adds a check to CI to make sure the symbols service can actually create a table in sqlite3

Here's what the CI check will look like if it fails:

Running sanity check...failed ❌ Binary was compiled with 'CGO_ENABLED=0', go-sqlite3 requires cgo to work. This is a stub

and if it passes:

Running sanity check...passed ✅

sourcegraph-bot · 2021-09-28T01:33:00Z

Notifying subscribers in CODENOTIFY files for diff 24b34be...1024d96.

Notify	File(s)
@christinaforney	doc/dev/getting-started/quickstart_1_install_dependencies.md
@keegancsmith	cmd/symbols/Dockerfile cmd/symbols/build.sh cmd/symbols/go-build.sh cmd/symbols/internal/sqliteutil/register.go cmd/symbols/internal/symbols/search.go cmd/symbols/internal/symbols/search_test.go cmd/symbols/internal/symbols/service.go cmd/symbols/internal/symbols/service_test.go cmd/symbols/main.go

chrismwendt added 3 commits September 27, 2021 19:04

symbols: replace pcre lib with a Go function (fixup) (#25401)

c2af7ff

use a musl compiler, enable cgo, add a sanity check

b112547

add CI check

1024d96

chrismwendt merged commit 3221127 into main Sep 28, 2021

chrismwendt deleted the fix-symbols-musl branch September 28, 2021 01:38

chrismwendt mentioned this pull request Sep 28, 2021

symbols: fix CI check when in docker #25424

Merged

chrismwendt mentioned this pull request Oct 27, 2021

docs: remove musl-cross instructions #26752

Merged

Provide feedback