Skip to content
This repository has been archived by the owner on Sep 30, 2024. It is now read-only.

deploy-sourcegraph, deploy-sourcegraph-docker: generate update-docker-tags params from allDockerImages list #15896

Closed
bobheadxi opened this issue Nov 18, 2020 · 0 comments · Fixed by #16227, sourcegraph/deploy-sourcegraph#1382 or sourcegraph/deploy-sourcegraph-docker#187
Closed

deploy-sourcegraph, deploy-sourcegraph-docker: generate update-docker-tags params from allDockerImages list #15896

bobheadxi opened this issue Nov 18, 2020 · 0 comments · Fixed by #16227, sourcegraph/deploy-sourcegraph#1382 or sourcegraph/deploy-sourcegraph-docker#187
Assignees
@bobheadxi
Labels
debt Technical debt. estimate/1d
Milestone
Dist: 2020.11.30

Comments

@bobheadxi
Copy link
Member

bobheadxi commented Nov 18, 2020 •
edited
Loading

TIL we have a list of all our images! https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/enterprise/dev/ci/ci/pipeline-steps.go#L12-42

There should be no need to hardcode this :)

Wildcarding on all index.docker.io/sourcegraph did not work in the past btw, because of exceptions in our images making things difficult. decided being explicit was the way to go
@bobheadxi bobheadxi self-assigned this Nov 18, 2020
This was referenced Nov 18, 2020
Merged
Merged
@bobheadxi bobheadxi added this to the Dist: 2020.11.16 milestone Nov 18, 2020
@sourcegraph-bot sourcegraph-bot mentioned this issue Nov 18, 2020
Closed
39 tasks
This was referenced Nov 18, 2020
Merged
Merged
Merged
This was referenced Nov 29, 2020
Merged
Merged
Merged
@sourcegraph-bot sourcegraph-bot mentioned this issue Nov 30, 2020
Closed
29 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bobheadxi bobheadxi

Labels
debt Technical debt. estimate/1d
Projects
None yet
Milestone
Dist: 2020.11.30
2 participants
@pecigonzalo @bobheadxi