Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework delete files method #16

Closed
texhex opened this issue Dec 20, 2017 · 2 comments
Closed

Rework delete files method #16

texhex opened this issue Dec 20, 2017 · 2 comments
Labels
bug enhancement

Comments

@texhex
Copy link
Member

texhex commented Dec 20, 2017

As of now, the installer uses the InstallDelete section to remove files. However, if a file that should be deleted is locked (which can happen for fonts), there is no error that a file can not be deleted and old files might remain active.

Maybe all entries in InstallDelete should be moved to a script based delete method that first uses the "normal" delete and if this doesn't work, use MoveFileEx (e.g. https://www.codeproject.com/Tips/1193043/Inno-Setup-Cleanup-Extra-Files) which will delete the file upon next restart.
@texhex
Copy link
Member Author

texhex commented Dec 21, 2017

See issue 362 in Hack repo: source-foundry/Hack#362

@texhex texhex added the bug label Dec 21, 2017
texhex added a commit that referenced this issue Dec 21, 2017
@texhex
Redesigned file deletion code (Issue #16)
6b31d8e
@texhex texhex mentioned this issue Dec 21, 2017
Closed
@texhex
Copy link
Member Author

texhex commented Dec 21, 2017

Fixed in v1.5.0, closing issue.

@texhex texhex closed this as completed Dec 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@texhex