Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup everything for sotopia in one script #122

Merged
merged 45 commits into from
Jun 26, 2024
Merged

Setup everything for sotopia in one script #122

merged 45 commits into from
Jun 26, 2024

Conversation

ProKil
Copy link
Member

@ProKil ProKil commented Jun 21, 2024 •
edited
Loading

📑 Description

To try out: poetry install; sotopia install

Support automatically setup redis dependency for all combinations of the following:

  • With and without docker
  • Linux, Windows, and MacOS
  • Load database or start from empty

Won't be supported: Windows + without docker.

  • Test default setting on test-runner.
  • Prompt the user that they need permission to run docker.
  • Prompt when previous rdb exists
  • Install redis w/ and w/o docker on Linux, Mac, and Windows
  • Download database from default and custom url
  • Start Redis with the database
  • CLI args + Rich prompts

Leave to another PR:

  • function to allow hosting with custom url and port
  • set REDIS_OM_URL

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed
  • Branch name follows type/descript (e.g. feature/add-llm-agents)
  • Ready for code review

ℹ Additional Information

@codecov Codecov
Copy link

codecov bot commented Jun 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 56.91824% with 137 lines in your changes missing coverage. Please review.

Project coverage is 61.75%. Comparing base (5818a89) to head (a88c911).

@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   59.99%   61.75%   +1.76%     
==========================================
  Files          47       55       +8     
  Lines        2402     2714     +312     
==========================================
+ Hits         1441     1676     +235     
- Misses        961     1038      +77
Files Coverage Δ
sotopia/cli/__init__.py 100.00% <100.00%> (ø)
sotopia/cli/app.py 100.00% <100.00%> (ø)
sotopia/cli/benchmark/__init__.py 100.00% <100.00%> (ø)
sotopia/cli/benchmark/benchmark.py 23.43% <100.00%> (ø)
sotopia/cli/install/__init__.py 100.00% <100.00%> (ø)
sotopia/cli/rich_pixels/__init__.py 100.00% <100.00%> (ø)
tests/cli/test_install.py 100.00% <100.00%> (ø)
sotopia/cli/rich_pixels/_pixel.py 92.00% <92.00%> (ø)
sotopia/cli/install/menu.py 20.00% <20.00%> (ø)
sotopia/cli/install/install.py 58.72% <58.72%> (ø)

... and 2 files with indirect coverage changes

XuhuiZhou
XuhuiZhou requested changes Jun 22, 2024
View reviewed changes
pyproject.toml Outdated Show resolved Hide resolved
sotopia/install/cli.py Outdated Show resolved Hide resolved
XuhuiZhou
XuhuiZhou requested changes Jun 22, 2024
View reviewed changes
sotopia/install/cli.py Outdated Show resolved Hide resolved
@ProKil ProKil marked this pull request as ready for review June 24, 2024 02:35
@ProKil ProKil requested review from XuhuiZhou, lwaekfjlk and ruiyiw June 24, 2024 14:31
XuhuiZhou
XuhuiZhou approved these changes Jun 26, 2024
View reviewed changes
Copy link
Member

@XuhuiZhou XuhuiZhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I briefly looked through this and it looks great to me now! We can merge or wait for other people to double check?

@ProKil ProKil merged commit 701f2a8 into main Jun 26, 2024
8 checks passed
@ProKil ProKil deleted the feature/auto-setup-script branch June 26, 2024 17:36
@ProKil ProKil mentioned this pull request Jun 26, 2024
Closed
15 tasks
@ProKil ProKil added this to the 0.1.0 Release milestone Jun 26, 2024
@ProKil ProKil mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuhuiZhou XuhuiZhou XuhuiZhou approved these changes

@lwaekfjlk lwaekfjlk Awaiting requested review from lwaekfjlk

@ruiyiw ruiyiw Awaiting requested review from ruiyiw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@ProKil @XuhuiZhou @ruiyiw