Override provider from the db YAML #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorenmat
force-pushed
the
provider-fix
branch
5 times, most recently
from
b3c9358 to
4818c84
Compare
Allows us to override the provider in the database YAML file. This is intended to phase out the include and exclude namespace option, as that could give a strange binding between the operator and the services using it
blacksails
approved these changes
Mar 23, 2021
Comment on lines
+173
to
+177
| provider := dbprovider | ||
| if db.Spec.Provider != "" { | ||
| provider = db.Spec.Provider | ||
| } | ||
| switch provider { |
There was a problem hiding this comment.
Suggested change
| provider := dbprovider | |
| if db.Spec.Provider != "" { | |
| provider = db.Spec.Provider | |
| } | |
| switch provider { | |
| if db.Spec.Provider != "" { | |
| dbprovider = db.Spec.Provider | |
| } | |
| switch dbprovider { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows us to override the provider in the database YAML file.
This is intended to phase out the include and exclude namespace option, as
that could give a strange binding between the operator and the services using it